Expose parsed date parts. Invalid date if 'a' token parsed but no date parts parsed. #3045
Conversation
|
Thanks Maggie. I think this will help a lot! |
| @@ -5,14 +5,18 @@ import getParsingFlags from '../create/parsing-flags'; | |||
| export function isValid(m) { | |||
| if (m._isValid == null) { | |||
| var flags = getParsingFlags(m); | |||
| var parsedParts = flags.parsedDateParts.some(function (i) { | |||
There was a problem hiding this comment.
Please don't use some. Its not supported on IE8 :) You can put it in utils, and use the Array.prototype if exists (but don't modify Array)
|
@maggiepint wow, that is a neat fix! We've had this for forever. Just get rid of |
|
Oh IE8. You are 👎 |
… flags. Change isValid to cause date to be invalid if only token parsed is meridiem.
maggiepint
force-pushed
the
parsingFlags
branch
from
627a573
to
d77aa58
Compare
|
Now works with technology ancient history. |
|
@ichernev I did the pseudo-polyfill the same way you do them since I figured that's what you would want. I'm curious though, what is your reasoning for using that particular pattern, as opposed to a regular polyfill, or even just creating a more plain wrapper function that takes the array as a parameter? To be clear, I know reasons in general why people are opposed to polyfills. I just want to know your reasons. |
|
Merged in e7bb14a |
Expose parsed date parts. Invalid date if 'a' token parsed but no date parts parsed.
PR resolves #3037 and #2986
The date parts parsed are exposed in parsingFlags().parsedDateParts array. Array only has date parts at indexes parsed.
Because actual date parts parsed is being tracked now, it is possible to modify isValid to evaluate as false if no date parts are being parsed, but meridiem indicator was parsed.
This resolves a current behavior where junk data can parse valid if it has the letters 'a' or 'p' in it (or whatever indicates meridiem in the specific locale).
Current behavior: